Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apiVersion declarative naming in pipelineRef and taskRef test for… #6814

Closed
wants to merge 1 commit into from
Closed

Use apiVersion declarative naming in pipelineRef and taskRef test for… #6814

wants to merge 1 commit into from

Conversation

JeromeJu
Copy link
Member

Changes

This commit adds apiVersion to the unsigned Tasks and Pipelines ie. unsignedV1beta1Task so as to be declarative when we are swapping to v1 storage version. No function change.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@JeromeJu
Use apiVersion declarative naming in pipelineRef and taskRef test for…
409fc30 
… Verification in V1

This commit adds apiVersion to the unsigned Tasks and Pipelines ie.
unsignedV1beta1Task so as to be declarative when we are swapping to v1
storage version. No function change.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 12, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abayer after the PR has been reviewed.
You can assign the PR to them by writing /assign @abayer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2023
@JeromeJu JeromeJu mentioned this pull request Jun 12, 2023
Merged
7 tasks
@JeromeJu
Copy link
Member Author

/hold
as #6444 (comment) suggested, we could accept an apiVersion in the helper.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@JeromeJu
Copy link
Member Author

opened #6815

@JeromeJu JeromeJu closed this Jun 12, 2023
@afrittoli
Copy link
Member

@JeromeJu wondering why this is closed now, the corresponding PR is still open.

@JeromeJu
Copy link
Member Author

JeromeJu commented Jun 16, 2023 •
edited
Loading

@JeromeJu wondering why this is closed now, the corresponding PR is still open.

Thanks @afrittoli , #6815 is now opened to be a better alternative for this:) instead of renaming the structs, it allows us to accept apiVersions to the trustedResources helper functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeromeJu @tekton-robot @afrittoli